| commit | d119f29c5a5daa6eb185964d5533ace82e0d9f76 | [log] [tgz] |
|---|---|---|
| author | [email protected] <[email protected]> | Fri Oct 27 15:48:41 2023 |
| committer | Copybara-Service <[email protected]> | Fri Oct 27 16:04:07 2023 |
| tree | 2fd72b9a8271f5c148095b83ec9d8907c26754b9 | |
| parent | 9c0632eeac7fecd3634714e59051a67c55b68323 [diff] |
Revert "Change over to using BoringSSL in place of net/der and net/cert/pki" This reverts commit 88963e95f705d2f63114b18be9015f562fbbd20a. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8766070381079393057 Sample failed build: https://ci.chromium.org/b/8766070381079393057 If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8766070381079393057&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4917011 Original change's description: > Change over to using BoringSSL in place of net/der and net/cert/pki > > This changes Chrome to use the core of the X.509 verification logic > from BoringSSL's libpki (which is these same files extracted from > chrome and with the Chrome dependencies removed). With this change > we move the source of truth for this code to BoringSSL. > > The other major consumer of this (google3) has already been converted > to use this code from BoringSSL. With this change both codebases use > the same thing, instead of differently translated copies. > > Bug: 1322914 > Change-Id: Ic8c51d5309359c34a4a2c416336327970c30b43e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4917011 > Reviewed-by: David Benjamin <[email protected]> > Owners-Override: danakj <[email protected]> > Commit-Queue: Bob Beck <[email protected]> > Reviewed-by: danakj <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1216147} > Bug: 1322914 Change-Id: I8ed8ed2365e7340a90c681b87a0e317d309a96b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984682 Commit-Queue: [email protected] <[email protected]> Bot-Commit: [email protected] <[email protected]> Owners-Override: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#1216163} NOKEYCHECK=True GitOrigin-RevId: 4763ed3ead5af1850833773aa4757e264fb6bd6e