CQ: don't treat the commit box as unchecked on network errors
BUG=309076
Review URL: https://codereview.chromium.org/83173008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237402 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/pending_manager.py b/pending_manager.py
index bc07d9c..7548be2 100644
--- a/pending_manager.py
+++ b/pending_manager.py
@@ -175,7 +175,16 @@
Calls _new_pending_commit() on all new review found.
"""
- new_issues = self._fetch_pending_issues()
+ try:
+ new_issues = self.context.rietveld.get_pending_issues()
+ except urllib2.URLError as e:
+ if 'timed out' in e.reason:
+ # Handle timeouts gracefully. Log them and pretend there are no
+ # pending issues. We'll retry on the next iteration.
+ logging.warn('request to fetch pending issues timed out: %s' % e)
+ return
+
+ raise
# If there is an issue in processed_issues that is not in new_issues,
# discard it.
@@ -243,21 +252,6 @@
description=issue_data['description'].replace('\r', ''),
messages=issue_data['messages']))
- def _fetch_pending_issues(self):
- """Returns the list of issue number for reviews on Rietveld with their last
- patchset with commit+ flag set.
- """
- try:
- return self.context.rietveld.get_pending_issues()
- except urllib2.URLError as e:
- if 'timed out' in e.reason:
- # Handle timeouts gracefully. Log them and pretend there are no
- # pending issues. We'll retry on the next iteration.
- logging.warn('request to fetch pending issues timed out: %s' % e)
- return []
-
- raise
-
def process_new_pending_commit(self):
"""Starts verification on newly found pending commits."""
expected = set(i.name for i in self.all_verifiers)
