| commit | a6dab71f12ad9de82165acadea1134c837dc3717 | [log] [tgz] |
|---|---|---|
| author | Hung-Te Lin <[email protected]> | Thu Jan 19 08:37:18 2017 |
| committer | ChromeOS Commit Bot <[email protected]> | Tue Jan 24 18:36:47 2017 |
| tree | 789aadd9c95978eb1ae1bb2d8528ce4fb033f00f | |
| parent | 6bf164d6049524c06ed5617d877345a1e0a5df96 [diff] |
pack_firmware: Fixes from review feedback.
Fixes from CL:428734.
- change vboot1/vboot2 to fmap/cbfs.
- extract cbfs contents directly without dump_fmap first.
- parse dump_fmap output by bash array and prevent off-hand operations.
- correct EC section size checking: should be '>=' instead of '>'.
- move dd & python into individual python helpers in utils folder.
BUG=chromium:674799
TEST=emerge-asuka chromeos-firmware-asuka
emerge-kefka chromeos-firmware-kefka
emerge-lumpy chromoes-firmware-lumpy
Change-Id: I8b7c136384a708535943df0b14fae08e5253d607
Reviewed-on: https://chromium-review.googlesource.com/430464
Commit-Ready: Hung-Te Lin <[email protected]>
Tested-by: Hung-Te Lin <[email protected]>
Reviewed-by: Hung-Te Lin <[email protected]>
(cherry picked from commit 3e730d2d05e0756b9f9eb0890d5b955beef52d66)
Reviewed-on: https://chromium-review.googlesource.com/431003
Reviewed-by: YH Lin <[email protected]>
Commit-Queue: YH Lin <[email protected]>
Tested-by: YH Lin <[email protected]>