| commit | cc6db7c33b3cbdb0a147edb4bf0bbcdf87e94557 | [log] [tgz] |
|---|---|---|
| author | Brian Norris <[email protected]> | Thu Dec 05 21:18:27 2019 |
| committer | Commit Bot <[email protected]> | Thu Dec 05 22:09:00 2019 |
| tree | 277785f0e0a964de65b8d7b5df4bf6e5dd22b625 | |
| parent | 66cdcb8c9632394207d4cd32e191d87d75184931 [diff] |
PRESUBMIT: exclude binaries from license check The license check isn't going to find much of any valid text in these, let alone text that matches our expected license headers. We keep a LICENSE file in here instead. Disable the license check for the bin/ directory. Fun fact: being fruitless doesn't stop pre-upload.py from spending a ton of time doing regex comparisons on these binaries. For example, I had to leave for lunch while Python was churning on a regex search over the 52 MB file in https://crrev.com/c/1954430 ! BUG=none TEST=.../src/repohooks/pre-upload.py Change-Id: If37c8f8e245dd987032302338eb0a492d52af143 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/intel-wifi-fw-dump/+/1954435 Tested-by: Brian Norris <[email protected]> Reviewed-by: Mike Frysinger <[email protected]> Commit-Queue: Brian Norris <[email protected]>