Clicking an element nested inside a checkbox/radio wrongly activates the ancestor input https://bugs.webkit.org/show_bug.cgi?id=321247 Reviewed by Darin Adler. WebKit's legacy-pre-activation behavior (the checkbox/radio toggle that happens before event dispatch) was applied to the first <input> found anywhere in the event path, including an ancestor checkbox/radio. Per the DOM specification, legacy-pre-activation behavior must only run on the event's activation target, which is the innermost node in the event path that has activation behavior. So when an element with its own activation behavior (e.g. a submit/reset <button>, an <a>/<area> link, a <summary>, or a <label><button type=button>) is nested inside a checkbox/radio, that inner element is the activation target and the ancestor input must not be toggled or activated. Introduce a virtual Node::hasActivationBehavior() (matching the spec concept and Blink's HasActivationBehavior), returning true for HTMLInputElement, HTMLButtonElement, HTMLLabelElement, and HTMLSummaryElement, and isLink() for HTMLAnchorElement (and HTMLAreaElement via inheritance). findInputElementInEventPath() now returns the innermost node with activation behavior, and only when that node is an <input>; otherwise no legacy pre-activation behavior runs. This fixes 14 subtests in Event-dispatch-single-activation-behavior.html, including the 12 that already pass in both Chrome and Firefox. The remaining failures match the ones Chrome and/or Firefox also fail. No new tests, rebaselined existing WPT test. * LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior-expected.txt: * Source/WebCore/dom/EventDispatcher.cpp: (WebCore::findInputElementInEventPath): * Source/WebCore/dom/Node.cpp: (WebCore::Node::hasActivationBehavior const): * Source/WebCore/dom/Node.h: * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isSystemPreviewLink): * Source/WebCore/html/HTMLAnchorElement.h: * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::hasActivationBehavior const): * Source/WebCore/html/HTMLButtonElement.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::hasActivationBehavior const): * Source/WebCore/html/HTMLInputElement.h: * Source/WebCore/html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::hasActivationBehavior const): * Source/WebCore/html/HTMLLabelElement.h: * Source/WebCore/html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::hasActivationBehavior const): * Source/WebCore/html/HTMLSummaryElement.h: Canonical link: https://commits.webkit.org/318853@main
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, Apple Books, and many other applications. For more information about WebKit, see the WebKit project website.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
Run the following command to clone WebKit's Git repository:
git clone https://github.com/WebKit/WebKit.git WebKit
You can enable git fsmonitor to make many git commands faster (such as git status) with git config core.fsmonitor true
Install Xcode and its command line tools if you haven't done so already:
xcode-select --installxcodebuild -downloadComponent MetalToolchainRun the following command to build a macOS debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release instead. If you also need debug symbols (dSYMs), run:
Tools/Scripts/build-webkit --release DEBUG_INFORMATION_FORMAT=dwarf-with-dsym
To build for an embedded platform like iOS, tvOS, or watchOS, pass a platform argument to build-webkit.
For example, to build a debug build with debugging symbols and assertions for embedded simulators:
Tools/Scripts/build-webkit --debug --<platform>-simulator
or embedded devices:
Tools/Scripts/build-webkit --debug --<platform>-device
where platform is ios, tvos or watchos.
You can open WebKit.xcworkspace to build and debug WebKit within Xcode. Select the “Everything up to WebKit + Tools” scheme to build the entire project.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild for both Products and Intermediates.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the WebKit on Windows page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari script sets the DYLD_FRAMEWORK_PATH environment variable to point to your build products, and then launches /Applications/Safari.app. DYLD_FRAMEWORK_PATH tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release instead of --debug.
To run other applications, for example MobileMiniBrowser, with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app --debug --iphone-simulator <application-path>
Open WebKit.xcworkspace, select intended scheme such as MobileMiniBrowser and an iOS simulator as target, click run.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk, --jsc-only, or --wpe to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.