| commit | da531cba2698417ff5922863e334909a013fce91 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <[email protected]> | Mon Feb 03 10:12:23 2025 |
| committer | Blink WPT Bot <[email protected]> | Mon Feb 03 10:34:33 2025 |
| tree | de496500f0ccd61a18c912b11d06e99b3b67ac7f | |
| parent | c3a6f612e35d45919cb0fcb83bfb860cb63e9809 [diff] |
[anchor] Avoid negative IMCB correctly with scroll shift. When a positioned box is tethered both to an anchor and the original containing block (e.g. position-area:top), and the relevant anchor edge is scrolled out of view, the inset-modified containing block size needs to be clamped to zero. At the same time, the inset that's auto should be adjusted so that the border box of the positioned element steers clear of the relevant anchor edges. We used to check if the inset at the opposite side of the anchor was zero, and adjust it accordingly if that was the case. But the comparison with zero wasn't correct when there was a default scroll shift. Rather than fixing it by comparing to the default scroll shift, clean up the code to check if the relevant inset is specified or not, which is what the code really wanted to do. Bug: 373874012 Change-Id: Ic98f63d8098eb0c8a7192b3bc0d1b5efa5194f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218569 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1414807}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!