| commit | ea64cbb31ddc4a0b6f3b0991cf4a98b943322398 | [log] [tgz] |
|---|---|---|
| author | Gavin Mak <[email protected]> | Thu Aug 19 22:26:22 2021 |
| committer | Gavin Mak <[email protected]> | Thu Aug 19 22:39:03 2021 |
| tree | e94ecaaf1ee4d6e65469de283b514c6fd80ace80 | |
| parent | bbaac3d6ec7a017ac7451e07f048c909bba1d7b6 [diff] |
Reland "Use Checks to display chromium-binary-size-table-view" This reverts commit bbaac3d6ec7a017ac7451e07f048c909bba1d7b6. Reason for revert: fix checks issues Original change's description: > Revert "Use Checks to display chromium-binary-size-table-view" > > This reverts commit 33dd9cccaa83b40ee8f5d4677ba994e4d446528e. > > Reason for revert: errors in this plugin break checks summary > > Original change's description: > > Use Checks to display chromium-binary-size-table-view > > > > Currently, the plugin only displays information in a cell format. This > > change displays this same information using a new table under the > > Checks tab. Both formats are still available. > > > > Bug: 1228935 > > Change-Id: Icaa809874a5ff1db9539a868577494425fcfde64 > > Bug: 1228935, 1241560 > Change-Id: I7125003d918ec8dd16c7b6bbaa98096457ed1b40 Bug: 1228935, 1241560 Change-Id: Idc6699803a68dd866e287c3d23f71e956471b0d0
The plugin queries the android-binary-size trybot for the current patchset on Gerrit, and gets the binary_size_plugin property. This property contains the metadata about the binary size metrics affected by the patchset in question. It then shows an inline table with the metric deltas + links to SuperSize output.
This plugin is configured via the chromium-binary-size.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).
An example chromium-binary-size.config is below (this enables the plugin on the chromium/src repo using the android-binary-size trybot:
[host] gerrit = "chromium-review.googlesource.com" [repo "chromium/src"] builder = "android-binary-size" bucket = "try" project = "chromium"
All changes to chromium-binary-size.config files are instantly reflected. There is no caching period or need to restart the server.
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit/plugins git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-binary-size cd chromium-binary-size
Use the script run-with-prod-data.sh (based on polygerrit-ui/run-server.sh). You may change some paths by setting environment variables, for example:
GERRIT_DIR="$HOME/gerrit" ./run-with-prod-data.sh
npm run wct-test