blob: 556ba8a9f795283b512547e40d8309169a820d7d [file] [log] [blame] [edit]
/* This file is a part of @mdn/browser-compat-data
* See LICENSE file for more information. */
import chalk from 'chalk-template';
import HTMLParser from '@desertnet/html-parser';
import { marked } from 'marked';
import { Linter, Logger, LinterData, VALID_ELEMENTS } from '../utils.js';
import {
BrowserName,
CompatStatement,
SupportStatement,
} from '../../types/types.js';
const parser = new HTMLParser();
/**
* Recursively test a DOM node for valid elements
* @param node The DOM node to test
* @returns The errors found during validation
*/
const testNode = (node): string[] => {
const errors: string[] = [];
if (node.type == 'TAG') {
const tag = node.tagName?.toLowerCase();
if (tag && !VALID_ELEMENTS.includes(tag)) {
// Ensure we're only using select nodes
errors.push(
chalk`HTML element {bold <${tag}>} is {bold not allowed}. Allowed HTML elements are: ${VALID_ELEMENTS.join(
', ',
)}`,
);
}
// Ensure nodes only contain specific attributes
const attrs = node.attributes.map((x) => x._name);
if (tag === 'a') {
if (attrs.length !== 1 || !attrs.includes('href')) {
// Ensure 'a' nodes only contain an 'href'
errors.push(
chalk`HTML element {bold <${tag}>} has {bold invalid attributes}. {bold <${tag}>} elements may only have (and must have) an {bold href} attribute; found {bold ${
attrs.length ? attrs.join(', ') : 'no attributes'
}}.`,
);
}
} else {
if (attrs.length > 0) {
// Ensure nodes (besides 'a') contain no attributes
errors.push(
chalk`HTML element {bold <${tag}>} has {bold invalid attributes}. Elements other than {bold <a>} may {bold not} have any attributes; found {bold ${attrs.join(
', ',
)}}.`,
);
}
}
}
for (const childNode of node.children || []) {
errors.push(...testNode(childNode));
}
return errors;
};
/**
* Test a string for valid HTML
* @param string The string to test
* @returns The errors found during validation
*/
export const validateHTML = (string: string): string[] => {
const errors: string[] = [];
const html = marked.parseInline(string);
const htmlErrors = HTMLParser.validate(html);
if (htmlErrors.length === 0) {
// If HTML is valid, ensure we're only using valid elements
errors.push(...testNode(parser.parse(html)));
} else {
errors.push(
chalk`Invalid HTML: ${htmlErrors.map((x) => x._message).join(', ')}`,
);
}
if (string.includes(' ')) {
errors.push(chalk`Double-spaces are not allowed.`);
}
if (string.includes('\n')) {
errors.push(chalk`Newlines are not allowed.`);
}
return errors;
};
/**
* Check the notes in the data
* @param notes The notes to test
* @param browser The browser the notes belong to
* @param feature The identifier of the feature
* @param logger The logger to output errors to
*/
const checkNotes = (
notes: string | string[],
browser: BrowserName,
feature: string,
logger: Logger,
): void => {
let errors: any = [];
if (Array.isArray(notes)) {
for (const note of notes) {
errors = validateHTML(note);
}
} else {
errors = validateHTML(notes);
}
if (errors) {
for (const error of errors) {
logger.error(chalk`Notes for {bold ${browser}} → ${error}`);
}
}
};
/**
* Process the data for notes errors
* @param data The data to test
* @param logger The logger to output errors to
* @param feature The identifier of the feature
*/
const processData = (
data: CompatStatement,
logger: Logger,
feature: string,
): void => {
for (const [browser, support] of Object.entries(data.support) as [
BrowserName,
SupportStatement,
][]) {
if (Array.isArray(support)) {
for (const s of support) {
if (s.notes) {
checkNotes(s.notes, browser, feature, logger);
}
}
} else {
if (support.notes) {
checkNotes(support.notes, browser, feature, logger);
}
}
}
};
export default {
name: 'Notes',
description: 'Test the notes in each support statement',
scope: 'feature',
/**
* Test the data
* @param logger The logger to output errors to
* @param root The data to test
* @param root.data The data to test
* @param root.path The path of the data
* @param root.path.full The full filepath of the data
*/
check: (logger: Logger, { data, path: { full } }: LinterData) => {
processData(data, logger, full);
},
} as Linter;